Skip to content

Conversation

marmeladema
Copy link
Contributor

Revert #73291 to confirm performance improvements

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2020
@marmeladema
Copy link
Contributor Author

r? @ghost

@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Jun 22, 2020

⌛ Trying commit c8905ec with merge fb2ce83a304d02fa8dd19155b04dd29b3c1dfa56...

@bors
Copy link
Collaborator

bors commented Jun 22, 2020

☀️ Try build successful - checks-azure
Build commit: fb2ce83a304d02fa8dd19155b04dd29b3c1dfa56 (fb2ce83a304d02fa8dd19155b04dd29b3c1dfa56)

@rust-timer
Copy link
Collaborator

Queued fb2ce83a304d02fa8dd19155b04dd29b3c1dfa56 with parent 1a4e2b6, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (fb2ce83a304d02fa8dd19155b04dd29b3c1dfa56): comparison url.

@ljedrz
Copy link
Contributor

ljedrz commented Jun 22, 2020

Doesn't seem like it was this one, huh; it was a net perf win regardless 🔥.

@marmeladema marmeladema deleted the hir-id-ification-confirm-perf-improvement branch June 22, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants